Add a Quick Action to insert an image using the keyboard in the WYSIWYG editor

Development
1

Hi everyone,

Part of the Quick Actions proposal, made by @mflorea and myself, included a quick image insertion action. The goal is to be able to find, embed and upload images to a page using the keyboard. Here is a preview of how it would look like:
demo

Here is also a simulated slow connection to show the loading animation and the caching of already discovered attachments:
demo_slow

@vmassol told me that the caching/loading animation would flicker on fast installations, and could disturb users.

Hence the vote: +1 to include a cache in the image insertion action.

What do you think?

Thanks,
Dorian.

2

The cache and loading animation are nice features, so +1 to have them. I don’t see any flicker in your first video but it’s hard to know without trying but I assume you’ve tested it and it looks good.

PS: We don’t usually use a VOTE for “small” topics. Instead we use a proposal tag. VOTE is quite heavy, see https://dev.xwiki.org/xwiki/bin/view/Community/Committership#HVoting

In general votes should be sent in case of big changes (whether it’s about code or about processes or people). A vote is mandatory for voting in new committers or from removing committers. It’s not necessary to send a vote when performing minor or even sometimes substantial modifications provided the author judges everyone would agree to them. This is called lazy consensus. However should someone objects to the code committed, the author must then be prepared to revert it if asked.

Thanks

3

Looks very nice BTW! :slight_smile:

4

I don’t see any flicker in your first video but it’s hard to know without trying but I assume you’ve tested it and it looks good.

It is the same amount of flickering as when I showed you, so I imagine it is noticeable?

PS: We don’t usually use a VOTE for “small” topics. Instead we use a proposal tag. VOTE is quite heavy, see Committership - XWiki

I fixed the tag :slight_smile:

Thanks,
Dorian.

5

I don’t remember noticing it. Do you see it flicker?

I just mentioned the topic to you because I recalled that we had some users who raised the issue for our navigation tree, where each node was loaded async with some “loading…” message and it was flickering and making it not nice to use.

6

I know it is here so I see it, but I don’t find it disturbing.
Thanks for the clarification!

7

Looks good, +1, thanks