Hello!
Context
When looking for a fix to the lack of alternative text for the location picker elements “pick” and “edit” on Loading... , I realized those were semantically buttons but in the DOM they were links. This difference is highlighted by the fact that they didn’t have any proper “href”.
This causes a few problems for everyone (see for example how the underlining appears on hover…), so I figured out we should replace them with HTML buttons. From then on, there’s one main choice to make: do we try to keep the style as close as possible as what it was, or do we update the design of these elements?
Proposal
Update the design of those elements to make them fit some of our standard button designs:
Opinion
I think the cost of this change in design is very low compared to the clarity and consistency it brings. The buttons don’t look too out of place with this “btn btn-default btn-xs” styles. This is pretty much the simplest and safest implementation.
We could put them in a button-group (shaped together like one pill), or even make them blend into the breadcrumb line shape, but these would need a bit more code and would be more prone to bugs. Personally I’m happy with how the proposed change looks already so I didn’t dig much further.
Conclusion
Are you in favor or against the proposal? Do you think another design would fit better?
For reference, here is the PR where I implemented this proposal (and the one where I’ll act depending on the results of this discussion). I’ll close the discussion in a week and proceed from there.
Thank you in advance for your answers!
Lucas C.
