Hi, I have been trying to solve this issue for a long time.
From what I have analyzed, this piece of code “$ services.localization.render (‘core.tags.list.label’)” responds to the translation of the word “Tags:” in different languages.
If the output (html) has changed and the existing test(s) is now broken, then yes, it is now mandatory to update the existing test with the new expected behavior.
I am not sure that the actual proposed change is the good one, but it depends on what you’ve done on the implementation side, while addressing the issue. The expected html code must match the actual one that the vm template produces.
I’m not sure what you are asking. If you’re asking whether it’s a good idea to update the test when there’s no tag, then ofc it is since that’s the point of the issue and the test must pass!
Now if you’re asking wether your HTML change is good then I don’t think it is, unless you have a good reason; could you explain why you’d keep the DIV with the class and id if there’s not tag. I mean it could be the right thing to do but it needs explanations.
Could you explain what is the regression? (please always try to be as precise as possible and make it easy for reviewers to understand what you mean). Is it that the “created by” text is moved to the left? The regression is not removing the DIV, it’s that the other part is moved. So either you fix the CSS or we keep the DIV (probably simpler I agree).
By possible regression I mean that the text “created by” the text is moved to the left. To keep “created by” on the right I propose to have DIV even when there are no tags
The new solution is not to delete DIV when there are no tags, but to delete “core.tags.list.label” when there are no tags because “core.tags.list.label” is the translation of the word “Tags:”. If we do not display “core.tags.list.label” when there are no tags, the user will not see the word “Tags:”
