The gallery macro’s maximize/minimize button currently uses two hard-coded GIF images, which don’t fit a page with a white background and ignore the icon theme. None of the existing icon names describe an expand/collapse-to-fullscreen action. arrows could stand in for “expand”, but nothing matches “compress”.
Do you agree with adding this pair of names to the IconSet?
Are arrow-expand / arrow-compressmaximize/minimize good names?
If nobody objects within a week, I’ll consider the proposal accepted. I’ll then update PR #4242 and the icon documentation to match what we decide if it gets merged.
Thanks for reading, I’m looking forward to your feedback
Lucas C.
@CharpentierLucas +1 but I’d like that we verify if there are icons for this in other icon sets (for ex Glyphicon (Bootstrap) and Elusive - see https://design.xwiki.org/xwiki/bin/view/Proposal/XWiki%20Icon%20Set ). That would ensure that the icon is common enough (finding just the mapping for 2 icon sets is a bit small for a good stat). I’m not too worried since that seems like a common icon, but I’d like that we follow our process.
If there’s a need for a new icon, the XWiki icon set can be extended. Such an extension is a non reversible change, it should be discussed with the community on the forum. In the proposal, make sure to provide a mapping for at least four icon themes: Silk, FA4, FA5, Glyphicons and the Material Icons.
