Hello again
After upgrading 11.3 to 11.10.4, I noticed that when using the “save” action, the comment is wiped …
Was this an intended change or something with my setup?
Best regards
Definitely not intended but I cannot reproduce this (and first time I see a report of something like this) so I don’t have much idea of what could be wrong.
Do you have that only with pages created before the upgrade or with new pages too ?
Thank you for your swift reply. I have in xwiki.cfg:
xwiki.editcomment=1
xwiki.editcomment.mandatory=0
xwiki.editcomment.suggested=1
that is probably not the default …
I could not identify what triggers the wipe (probably some java script called by the save event)
I removed the xwiki.cfg entry but that has no additional effect, since the same is configured in the Admin UI … there, all is set to yes (Summaries; Summaries Mandatory, Minor edits)
I was done on purpose for Loading... with XWIKI-17077: Pre-filled text from Summary field should be cleared aut… · xwiki/xwiki-platform@e081ac7 · GitHub and XWIKI-17077: Pre-filled text from Summary field should be cleared aut… · xwiki/xwiki-platform@2c84307 · GitHub . Now, why do you want to keep the comment text after a Save? It’s very easy to forget about it and do other changes that don’t correspond to the written message, especially if you use the shortcut keys to save.
@mflorea
Thank you for pointing this out. At least I know that this is not a issue with my environment.
The reason I would like to keep it is simple:
Autosave is not mature enough and we often use the wiki from abroad on the laptop. There are many circumstances where you close a browser, or a window, or change the network, have the laptop crash while working onsite or … where you can loose the work at hand. So we are used to save the page manually as minor from time to time or when important or complex information was added. Opposed to the request in jira (which is probably more settings related), we do not micro comment page edits. For a documentation, we probably add a comment to add an additional device, but not every setting of the device will be commented and saved as minor. In our case, there might well be 10 or more saves with the same comment “added device configuration XYZ”, where all the saves are “backup” copies. Since we enforce a comment, one would always need to repeat the comment (well, the browser will suggest after some characters, but there might be many similar). As I know my fellows and also myself, if you always have to send time to select or re-type the comment, we will probably less or not at all save in between … which might end up loosing information.
OK looks like I misunderstood which “comment” you were referring to. I was actually talking about the comments you have at the bottom of the page. We indeed decide to reset the save comment after save considering that keeping it was creating more harm than good (the logic was that if you always use the same comment then having a comment does not make much sense in the end.)
What we could do is to reset the comment on save only if the comment is not mandatory. But I’m not fully sure how to justify this behavior. I would like to know what the others think.
Feels like it defeat the purpose of the mandatory comment option which is to put meaningful comment and not any comment.
… sometimes solutions are easier than imagined … I simply use the space character as a comment or something that is predicted by the browser uniquely, like !AutoSave … “problem” “solved” …