Thanks again @atripp.
Some style comments if you have the energy to fix them:
- When using the code macro you could always specify the language as otherwise 2 problems occur: 1) performance is dropped a lot since pygments needs the analyze the content to try to infer the language and 2) in a lot of cases the wrong language will be inferred. Thus for velocity content for ex, always use
language='velocity'
for velocity content (you’ll see that it’ll remove all the red boxes for example ;)). Added to https://dev.xwiki.org/xwiki/bin/view/Community/DocGuide#HMacros - When using links please always use wiki link syntax and not URLs since 1) this means that if we rename pages in the future links specified as URL won’t be refactored automatically and 2) URL links are indicated as external links which is not correct since the links are internal. See https://dev.xwiki.org/xwiki/bin/view/Community/DocGuide#HLinking
- Using ##…## everywhere would be great as it makes the code more readable IMO. I learnt this with my editor at Manning when I wrote my JUnit in Action book
Thanks