Inject not yet installed macros in the WYSIWYG macro picker

[lucaa]

Hello all,

I’ve seen this in the released version of XWiki, hence my late feedback about it - I know it would have been better to bring this up before implementation.

@tmortagne

To avoid problems, I propose to list only macros from extensions which:

One more information is essential for this objective, the status of the extension that would be installed. From what I tested, there is no information in the wysiwyg dialog about whether the extension is recommended or not.
Since when installing from extension manager the recommended status of an extension is very visible - including it being used for default filtering - I think it needs to be the same when installing from the editor, otherwise this feature is introducing a stability risk.

@tmortagne

Regarding what happen after you click “Install”, I honestly think it does not worth it to complexify the UI with a new dedicated step and progress. As @mflorea indicated, it’s not like it was the only way to install an extension.

Currently the UI does not warn clearly enough about the fact that a whole new feature will be added to the wiki in order for that macro to be brought in.

For example, take the following situation:

• an admin edits a page, with a somewhat “experimental” mindset
• they see the macros in the wywisyg
• they pick diagram or ideasrecent macro from the list and click Next (Install)
• they get transparently to the next step (not even a confirmation message)
• they fill in the parameters and add the macro in their page, or not even, because they don’t know what to fill in, it doesn’t actually matter that much

They exit the edit mode:

• now, a new application is displayed in the applications menu on their wiki (Diagram or Ideas).

In some situations this is probably what the users are expecting, or they find this normal, since they wanted to add this new feature to the wiki.

However, I can easily imagine situations where the users are not really aware that they are adding an application to their wiki, nor what exactly does that application. Also, it’s an administration action that is outside the administration, so I can imagine admins that are doing this not being aware that they are making changes to the wiki that are of the same “gravity” level as the actions from the administration.

Otherwise it’s a very interesting feature, we just need to make sure we warn properly the admins of what they’re about to do.