Move Google Analytics to a contrib extension

[MichaelHamann]

+1, thank you!

[surli]

Hi Vincent,

thanks for bringing that up. We recently discussed that with @tmortagne and the outcome of the discussion was more to just get rid of the feature since as you mentioned it will stop working in 2023 and it shouldn’t indeed be bundled in XS.

So I’m +1 that we create a contrib repo if someone wants to contribute to a new extension for GA 4, but I don’t see the point of migrating our existing code there for now so I’d be -0 for that.

Now definitely +1 to remove our current implem of GA from XS. Note that I don’t recall but maybe there’s some templates files that would be impacted too to inject the GA code in XWiki pages?

[vmassol]

@surli

but I don’t see the point of migrating our existing code there for now so I’d be -0 for that.

Note that once it’s contrib, it’s up to anyone to decide what they want to do and there’s no voting by the Core dev team anymore.

@surli

Note that I don’t recall but maybe there’s some templates files that would be impacted too to inject the GA code in XWiki pages?

The JSX is in XWiki.GoogleAnalyticsCode but it’s onDemand so indeed there must be some place that calls it, but I can’t find it in xwiki-platform.

[mleduc]

+1 Thanks

[vmassol]

@vmassol

The JSX is in XWiki.GoogleAnalyticsCode but it’s onDemand so indeed there must be some place that calls it, but I can’t find it in xwiki-platform.

Strangely, on xwiki.org it’s set to be “on this wiki” which explains why it works… So maybe there’s actually a bug in the code

[vmassol]

Maybe that would explain:

• Google Analytics is enabled but not works
• Google Analytics is on but not working

[vmassol]

Seems it’s like this since XWIKI-6579: Make it easier to enable and configure Google Analytics · xwiki/xwiki-platform@29df77e · GitHub ie since XWiki 3.2M3 (Loading...)

[tmortagne]

+1 to get rid of the current Google Analytics support

[mflorea]

+1

Thanks,
Marius

[vmassol]

I’ve noticed that there’s already an application-googleanalytics extension at GitHub - xwiki-contrib/application-googleanalytics: Google Analytics Embed Extension (see also XWiki Application - Google Analytics Embed Application (XWiki.org)).

It’s an extension that allows embedding GA graphs in wiki pages.

I see 3 options:

• Option 1: Add a new feature to the application-googleanalytics extension, i.e. the collection of GA stats, and thus refactor the extension into 2 subdirectories (one for the GA collection/registration and one for the reporting part). This means 2 extensions from an XWiki POV but released together.
• Option 2: Rename the application-googleanalytics extension into application-googleanalytics-reports (or application-googleanalytics-reporting), add a pom EM feature entry, and create a new application-googleanalytics extension for the GA colleection/registration. This means having to re-release application-googleanalytics-reports. I think there’s also the problem with EM upgrades for users who have had the application-googleanalytics extension installed.
• Option 3: Add a new repo and don’t touch the existing application-googleanalytics one, using a suboptimal name. For example: application-googleanalytics-tracker or application-googleanalytics-collect or application-googleanalytics-registration or …

The main pro for option 1 is to have everything related to GA in one place. The main con for it is that I don’t know the status of the current code for the reports and I’ll release a new version for the code moved.

Option 2 is simpler and probably cleaner vs option 1 but I think it can cause problems with EM.

Option 3 is by far the simplest but with a suboptimal extension/repo name.

Any preference?

Thanks

[surli]

I think I would go for option 1: worst case scenario you release it and the reporting does not work anymore (but I guess it means it was already not working anymore on recent versions of XWiki) and we’ll need to release a bug fix for fixing it (which is good meaning we’ll fix it).

[tmortagne]

The age of the extension does not give me much confidence on its working status, but it does have 4 active installs…

@vmassol

and create a new application-googleanalytics extension for the GA colleection/registration

-1 for that, stealing the ID of an existing extension for something completely different is a very bad idea

I would suggest something like Option 2 but without reusing the old ID: just refactor GitHub - xwiki-contrib/application-googleanalytics: Google Analytics Embed Extension to have two extensions ( application-googleanalytics-reports/ with the old one as feature and application-googleanalytics-tracker/, or some other names) instead of one.

[MichaelHamann]

I think the tracking and the chart features are really quite different features. Therefore, I’m -0 for 1 and +1 for 3 and +1 for the option suggested by Thomas.

[surli]

I’m also fine with Thomas suggestion, provided that you document on the extension page the extension moved.

[vmassol]

@tmortagne

I would suggest something like Option 2 but with without reusing the old ID: just refactor GitHub - xwiki-contrib/application-googleanalytics: Google Analytics Embed Extension to have two extensions ( application-googleanalytics-reports/ with the old one as feature and application-googleanalytics-tracker/, or some other names) instead of one.

ok, that’s option 1 actually.

Now @MichaelHamann says -0 for option 1 yet he says he’s ok with the option suggested by Thomas Could you confirm you’re ok with it? Of so, it seems the 3 of you are in agreement about option 1.

[mflorea]

@vmassol

Now @MichaelHamann says -0 for option 1 yet he says he’s ok with the option suggested by Thomas Could you confirm you’re ok with it? Of so, it seems the 3 of you are in agreement about option 1.

So I guess the question is whether to use the same GitHub repo (option 1), and thus the same version (released together) or to use 2 separate repos (option 3) and thus have different versions (released separately). I’m slightly more for option 1.

Thanks,
Marius

[vmassol]

@mflorea

So I guess the question is whether to use the same GitHub repo (option 1), and thus the same version (released together) or to use 2 separate repos (option 3) and thus have different versions (released separately). I’m slightly more for option 1.

yep that’s exactly the question, thanks for phrasing it more simply Released together, yet with 2 different extensions so that users can install only the extension they need.

[MichaelHamann]

@vmassol

Now @MichaelHamann says -0 for option 1 yet he says he’s ok with the option suggested by Thomas Could you confirm you’re ok with it? Of so, it seems the 3 of you are in agreement about option 1.

Ah, I think I misunderstood this here, I thought the idea was to have two different repositories… I don’t see that these two extensions will have much in common but anyways, if you want to have them both in one repository, why not.

[mleduc]

@mflorea

So I guess the question is whether to use the same GitHub repo (option 1), and thus the same version (released together) or to use 2 separate repos (option 3) and thus have different versions (released separately). I’m slightly more for option 1.

I’m also +1 for two separate extensions and repositories, and +0 for a single repo for both extensions.

[vmassol]

@mleduc

I’m also +1 for two separate extensions and repositories, and +0 for a single repo for both extensions.

Then the question is: option 2 or option 3 and if option 3 what repo name?

So right now we have:

• Thomas: option 1
• Simon: option 1
• Marius: option 1
• Michael: option 2 or 3
• Manuel: option 2 or 3
• Vincent: option 1 (for simplicity and because I can’t find a good name for option 3 and the extensions are small, the domain (GA) is small and I feel it’s ok to put everything related to that domain together)