New Filter Streams Extension: GitHub Importer

No it’s fine to keep both, they are different modules. Each needs to have the documentation that matches what it contains. so the UI one will document the new UI and the filter one is good as it is now; it’ll just need an info box to explain that there’s a better and simpler UI available to use and point to the new UI extension.

1 Like

I pushed from Linux, I think that is creating the problem.
The tests are passing on Linux but failing on Windows with same errors as Jenkins.
And it is also adding unneeded characters in the test when I test on windows.

Is there an option to change Jenkins agent to be compatible with Linux instead of Windows?

We need to set it to Linux since there are also functional tests coming in the next releases and they do not work on windows (we discussed the errors of XWiki environment not getting set on Windows but worked on Linux).

Or is there a better solution?

The agents are on linux.

1 Like

Ok, so I fixed the tests and tested on windows which passed and the extension built successfully. However the CI build is still failing on tests.
I am looking into this.

Finally, the problem was in the code which was causing improper order of tests on different devices.
I have fixed the code and tests, then tested on Linux + Windows and then pushed the changes to see on Jenkins CI and the build passed successfully.

I have also released the extensions:

  1. GitHub Importer Filter v1.1
  2. GitHub Importer UI v1.1

Release 1.1 on JIRA: https://jira.xwiki.org/projects/GHIMPORT/versions/18572
I will define the Roadmap 1.2 in the morning.

Thanks @vmassol for all the help you did on the Chat! :slight_smile:
See you!

Roadmap 3 (v1.2)

See the release information on JIRA: https://jira.xwiki.org/projects/GHIMPORT/versions/18588
For issues, click Issues in version.
Total issues = 10 + 1(MARKDOWN-24) = 11
Release date = 24th july / Friday.

Found a very good real life wiki today: https://github.com/nebulasio/wiki/wiki

And:

1 Like

Roadmap 4 (v1.3)

See the release information on JIRA: https://jira.xwiki.org/projects/GHIMPORT/versions/18601
For issues, click Issues in version .
Issues: 6
Release Date: 7 Aug, 2020 / Friday

Hi @vmassol , good to see you’re back from holidays. I hope you had a good time!
Here’s the summary what happened while you were gone:

  1. Resolved the following issues (before and after final exams): https://jira.xwiki.org/projects/GHIMPORT/versions/18588
  2. The hierarchical sorting and docker tests took more time than expected, so either I had to drop MD syntax issue or extend the release date. I thought it would be better to release than extending the date.
  3. Released v1.2: https://forum.xwiki.org/t/github-importer-application-1-2-released/7228
  4. Assigned MD syntax issue for v1.3: https://jira.xwiki.org/browse/GHIMPORT-12
  5. And the roadmap for v1.3 as defined in the above post.

What I’ve done so far (locally, going to commit in a few hours):

  1. Folder import
  2. Zip import

i.e. Support Offline Importing (Requirement 8).

And also, my family is planning a trip for a few days (5-6 max) so I may not be available online in those days, however I will still take my laptop as I’ve decided (so the workload will not stack up). Also, if the work is incomplete / not good, I will spend the weekends on the work to complete and fix the issues. I will post here when I am back :slight_smile:
Thanks!

Thanks @haxsen for the update and for your work!

Thank you for the 1.2 release. Looking at https://jira.xwiki.org/projects/GHIMPORT/versions/18588 I was just a bit disappointed that you removed all the scheduled issues that were interesting and that you pushed them to the next version 1.3. This means that you didn’t spend much time on the GitHub Importer in the past 2 weeks because the remaining issues were really really small (less than 1-2 days of work to finish all of them)… I had already mentioned to you that IMO you were a bit slow on the development speed and the problem is now even more acute.

There was a reason we had scheduled these issues for 1.2 and they were doable (by far) in the timeframe. I really wanted to have at least https://jira.xwiki.org/browse/GHIMPORT-12 which was an important one and useful for the xwiki project.

I think you’re not putting enough time in this project ATM. I’d love to know how you plan to fix this. If you’re having some specific difficulties, please let us know.

Yes, definitely. But it would have been better to finish them since there was ample time in 2 weeks to do them all.

What is folder import? How is that related to offline importing?

Please let’s make sure that this time you fully finish the planned roadmap, ok?

Thanks!

I assigned the v1.2 issues in accordance with the Final exams + Final Year Project presentation and demo (I talked about this before your vacations/holidays).

I have very less network availability at the moment, but I have an update. I’ve fixed 2 more issues locally (Only top level pages are imported, the importing was not done asynchronously).

Another update, the trip has shortened for 3 days only, hopefully I’ll be back on the day after tomorrow and continue the work.

This time, I’ll make sure to put my maximum effort + time and try my best to resolve as much issues as I can. Also I might be missing replies, I will talk to you in detail and reply to all your questions when I can.

Thanks!

Hi @vmassol , I am back from the trip. I will continue the work and start fixing the bugs from this morning (reached at night after traveling a long distance). I just saw you have commented on my commits, will be fixing everything very soon.

And thanks for the comments and feedback, that helps me and the extension to improve a lot. Hopefully I will make GitHub Importer this time as best as it can be.

Thanks :slight_smile:

When the repository is cloned already and the person does not want to create a zip and then use zip import.

Got it, I will do my best this month! :slight_smile:

Roadmap 5 (v1.4)

See the release information on JIRA: https://jira.xwiki.org/projects/GHIMPORT/versions/18616
For issues, click Issues in version .
Issues: 5 (more will be picked / created if finished) (+1 issue from Markdown extension)
Release Date: 20 Aug, 2020 / Thursday

We should include 1 more release (i.e. v1.5 which shall be released near September 6).

Released GitHub Importer v1.4

Date: 18 Aug (2 days earlier).
See: https://forum.xwiki.org/t/github-importer-application-1-4-released/7343
Now we have more time for final release (i.e. v1.5).
I will try my best to finish off this extension with good quality and tests (unit+functional).

Right now, I am thinking about more issues to create them on JIRA to include in v1.5.

One thing I would like to mention here that this forum does not seem so active as it used to be, that is because most of the communication is shifted on Chat (see: https://dev.xwiki.org/xwiki/bin/view/Community/Chat).

Roadmap 6 (for v1.5) coming soon!
Thanks :slight_smile:

Roadmap 6 (v1.5)

See the release information on JIRA: https://jira.xwiki.org/projects/GHIMPORT/versions/18631
For issues, click Issues in version .
Release Date: 7 Sept, 2020 / Monday
(Date can be changed on request).

I will do my best for this version and hopefully it will be great :slight_smile:

Thanks.

Released GitHub Importer v1.5

Date: 30 Aug (8 days earlier).
See: https://forum.xwiki.org/t/github-importer-application-1-5-released/7393

Hope this release is good! I tried my best for this release to fix as max issues as I can in less time, that means even working on weekends to finish the roadmap earlier.
I am writing a report for GSoC now and hopefully submitting the final evaluation tonight. :slight_smile:
And as I said I wanted to create 1 more release, so I am creating 1 more release (v1.6, release 7).

Roadmap 7 (for v1.6) coming soon.
Thanks!
:slight_smile:

1 Like

Cool! Thanks @haxsen :slight_smile: :+1:

1 Like

Roadmap 7 (v1.6)

See the release information on JIRA: https://jira.xwiki.org/projects/GHIMPORT/versions/18643
For issues, click Issues in version .
Release Date: 10 Sept, 2020 / Thursday.