To summarize, we have 2 settings:
-
xwiki.recyclebin
indicates whether a recycle bin is available -
canSkipRecycleBin
indicates whether a user can choose to skip the recycle bin
Behavior 1
When xwiki.recyclebin
is false, all the documents are always removed permanently.
Behavior 2
When xwiki.recyclebin
is true and canSkipRecycleBin
is false, the behavior is the same as before 12.8RC1, documents are always send to the recycle bin (including their attachments).
The same is true of the children if the user choose to remove them too.
When xwiki.recyclebin
is true and canSkipRecycleBin
is true, the behavior 2 applies if the user choose the first option (sending the document to the recycle bin), and the behavior 1 applies if the user choose to remove the document permanently/.
If the logic presented above is agreed upon, I will update the javadoc and hints to make this as clear are possible to devs and users.
Regarding the topic of the configuration, I agree that it is counter intuitive to place a document removal into a refactoring section.
However, afaicw no existing section fully match the scope of this newly introduced settings.
On possible approach could be to introduce a xwiki-platform-page-management
module dedicated to the management of the configurations of operations related to the pages.
In this case we could introduced a Page management
sub-section in the Editing
section.
WDYT?