CKEditor toolbar slops of end of page

Help / Discuss
#1

I’m another guy helping to migrate an old Mindtouch installation to XWiki. Have only just started playing around with the admin features, next I’ll be diving into scripting.

One of the first things I did was to add some additional buttons to the CKEditor toolbar, working purely through the Admin control panel. After I’m done and then open up the editor, it looks like this:
image

The toolbar is not staying confined to the editor area. This is a bit surprising and perplexing to me. Is there something I need to do manually to make it respond properly to the content area size?

BTW it is a bit odd to characterize the editor configuration according to which functions are disabled. So all the items that are checked are disabled, and I need to uncheck them to enable them. That is backwards to the way I would expect UI enablement to work. It’s not that big a deal because it’s only for the admins, but it was really stressing my brain out when I was working with it.

#2

Looks like a bug in XWiki (potentially a CSS one). Not that long ago the toolbar was refactored to fit on a single line (was on 2 before) and I wonder if we didn’t cause this type of regression when we did this. Maybe @mflorea knows?

I don’t know anything about this. All I can think of is that this strategy would allow to benefit from new functions automatically when they are added by CKEditor but I’m not sure if this is wanted or not (feels a bit weird to not fully control what we display). @mflorea would probably know too.

#3

You could report this in jira at https://jira.xwiki.org/issues/?jql=project%20%3D%20XWIKI%20AND%20component%20%3D%20"WYSIWYG%20Editor"

#4

Thanks for the quick reply. I’ve filed it in Jira: https://jira.xwiki.org/browse/XWIKI-18612.

I don’t know anything about this. All I can think of is that this strategy would allow to benefit from new functions automatically when they are added by CKEditor but I’m not sure if this is wanted or not (feels a bit weird to not fully control what we display). @mflorea would probably know too.

Since the editor philosophy in XWiki seems to be “only enable exactly the functions you need”, then it would make more sense (to me, at least) to only check the functions that are enabled. New functions that get rolled in would be unchecked by default.

Again, it’s not a big deal, just struck me as odd.

#5

That’s a feature of the floating tool bar. See my comment on https://jira.xwiki.org/browse/XWIKI-18612 .

The CKEditor administration section is simply exposing some standard CKEditor configuration options, such as removePlugins and removeButtons which act like an exclude list, considering that everything is enabled by default. This also goes hand in hand with the Advanced Content Filter (ACF) which disables features that are not supported by the content rules (syntax). Having an include list could be misleading because it doesn’t guarantee that those features will actually be enabled (because of ACF), while an exclude list guarantees that those features won’t be enabled.

#6

That’s a feature of the floating tool bar. See my comment on https://jira.xwiki.org/browse/XWIKI-18612 .

I responded there as well.