Clean up unused APIs in PropertyClass

Development
1

Hi everyone,

as part of my work on xwiki-platform-oldcore I performed some checkstyle clean up in PropertyClass which gave me the opportunity of checking the different APIs we have there and I discovered that there’s 2 methods which are not used nor implemented or overridden:

  • PropertyClass#initLazyCollections (doesn’t return anything doesn’t do anything)
  • PropertyClass#isValidColumnTypes(Property) (returns always true)

So the vote is for simply removing those APIs as they are doing nothing and I don’t know how to document them…

You can see the changes in [Misc] Fix checkstyle in PropertyClass and clean up unused methods by surli · Pull Request #5258 · xwiki/xwiki-platform · GitHub

Note that in the same PR I also changed the signature of another API: PropertyClass#setxWikiClass so that the argument takes a PropertyMetaClass instead of a BaseClass: the implementation performs a cast right away to PropertyMetaClass…

So I’m opening this vote for the removal of the 2 mentioned APIs, the vote is open for 2 days so that it’s included in next release. Here’s my +1.

2

Note: Regarding PropertyClass#isValidColumnTypes(Property) see my comments at [Misc] Fix checkstyle in PropertyClass and clean up unused methods by surli · Pull Request #5258 · xwiki/xwiki-platform · GitHub and below.

3

+1,

Thanks,
Marius

4

+1 too.

5

+0 for the removal of #initLazyCollections and #isValidColumnTypes. It should be painless, but so is moving them to legacy for example I guess.

But -1 for the signature change of #setxWikiClass that you mentioned.

6

Closing with 3 +1 and 1 +0. As requested by Thomas I made sure to keep the signature for `setxWikiClass`. Work done in [Misc] Fix checkstyle in PropertyClass and clean up unused methods (#… · xwiki/xwiki-platform@f3ff194 · GitHub