Deprecate api.XWiki#getSpacePreferenceFor() methods using space as String

Development
#1

I propose that we deprecate and move to the legacy modules the api.XWiki#getSpacePreferenceFor(String, String) (https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java#L1163) and api.XWiki#getSpacePreferenceFor(String, String, String) (https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java#L1178).

The main reason is that these methods are using spaces as String and, in the context of the Nested Spaces structure (since XWiki 7.2), the spaces are not properly resolved, meaning that a String A.B will be considered a single space named A.B instead of a space hierarchy with space A as a parent of space B.
Moreover, these methods are calling the method xwiki.XWiki#getSpacePreference(String, String, String, XWikiContext) (https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java#L2947), which is also deprecated since 7.4M1.
Finally, in the xwiki-platform project, there are only 2 occurrences of these methods:

This vote is open for one week: it will be closed on Friday, September 2nd.

Thanks,
Alex

#2

+1

#3

+1, Thanks

#4

+1

Thanks,
Marius

#5

+1