Hi everyone,
I incidently discovered recently that we have a DeleteSpaceAction and a deletespace.vm template related.
AFAICS this action is here to allow deleting an entire space, and it mainly displays the document about to be deleted, before using the implementation of Delete for performing actual deletion.
It been introduced with Loading...
The thing is that I don’t think we use that action anymore at all in XWiki Standard, the only actual reference I can see is in the DocumentTreeMacros for some data of the space node, but I don’t see it used in the UI.
I quickly tested it, and apparently the template is a bit buggy (doesn’t list all pages of the space) and I don’t think it offers the various protection we put in place for delete UI (e.g. asking questions in case of deletion of a page containing used xclass).
Now note that this action appears to be used in few extensions, see: Sign in to GitHub · GitHub
It is also used a bit for the testing framework of XWiki.
So my proposal is to deprecate the DeleteSpaceAction and the related template and move both of them to legacy: we would need to use another implementation for the testing framework but I think we can just rely on Delete action. (to be confirmed)
wdyt?