Hi! I’m reviving this discussion to talk a bit more about what happened and discuss what will happen.
We implemented a new variable system in XWiki based on CSS properties. CSS properties pretty much mirror what we had in LESS variables. However, I think it’d be interesting to take this opportunity to change the font size system to match what we proposed here and in Reworking our font-size CSS: rem vs em
My idea is that we drop support of font-size-base in CSS variables completely (in favor of browser level user preference), it does not get a px value from the Flamingo colortheme anymore, while we keep @font-size-base in LESS.
This will mean that if the user changed their preference, or if the admin set a specific @font-size-base in the colorTheme, both basic font-sizes will not match.
This has a few implications:
- All uses of font sizes in XS should be migrated in the same version, or at least they should all be in the same variable system for recommended versions.
- When migrating to the CSS variable based versions of XWiki, the old customizations and extensions will not follow the same sizes as everything else for their font-sizes. By default, this should be the same, but if the admin or user customized them, it will be different. Migrating the styles to CSS should be easy (same variable names for font-sizes) and fix the difference in font-sizes.
I’m not sure how we could start using browser preferences for font-size better than this, please share your thoughts if you have a better plan or oppose to this change of font-size-base in CSS properties.
Thanks,
Lucas C.