Hibernate.cfg.xml in XWiki 18.8.0

Help / Discuss
,
1

Hi! I just updated from XWiki 18.8.0 to XWiki 18.8.0 on an Ubuntu 22.04.5 LTS box.

By inspecting the differences in the main config files included in the downloaded WAR file, I found the following block in hibernate.cfg.xml:

   <!-- Configuration for the default database.
         Comment out this section and uncomment other sections below if you want to use another database.
         Note that the database tables will be created automatically if they don't already exist.

         If you want the main wiki database to be different than "xwiki" (or the default schema for schema based
         engines) you will also have to set the property xwiki.db in xwiki.cfg file
    -->
    <property name="hibernate.connection.url">jdbc:hsqldb:file:${environment.permanentDirectory}/database/xwiki_db;shutdown=true</property>
    <property name="hibernate.connection.username">sa</property>
    <property name="hibernate.connection.password"></property>
    <property name="hibernate.connection.driver_class">org.hsqldb.jdbcDriver</property>
    <!-- Control whether or not the compression of some tables (like the history table) is enabled.
         The default behavior depends on the database, currently:
         * enabled by default for MySQL/MariaDB
         * disabled by default for Oracle
         * this property has no effect in other databases
     -->
    <!--
    <property name="xwiki.compressionAllowed">true</property>
    -->

    <property name="hibernate.connection.charSet">UTF-8</property>
    <property name="hibernate.connection.useUnicode">true</property>
    <property name="hibernate.connection.characterEncoding">utf8</property>

    <mapping resource="xwiki.hbm.xml"/>
    <mapping resource="feeds.hbm.xml"/>
    <mapping resource="instance.hbm.xml"/>
    <mapping resource="notification-filter-preferences.hbm.xml"/>
    <mapping resource="mailsender.hbm.xml"/>

Does it make sense to insert the block affecting the property xwiki.compressionAllowed into the block affecting HSQLDB? It is confusing to me.

I checked whether that line order is the result of a local change, but those are the lines in the actual hibernate.cfg.xml included with the distribution WAR file.

Thanks!