Now, there is one major and fundamental quality of all those proposals that my current proposal doesn’t have (I kept the best for the end 
): all those proposals are compatible with all icon themes (since all they do is use a single heart icon that doesn’t change color), while this proposal is rather specific to font awesome, because it uses 2 heart icons (an empty / inactive one and a full / active one).
While this may be rendered compatible with silk as well, by using various “hacks”, the icon theme API of XWiki does not have 2 hearts : https://design.xwiki.org/xwiki/bin/view/Proposal/XWiki%20Icon%20Set#HXWikiicons, so this proposal is not compatible with the icon API of XWiki.
So, next question after “do you like it?” is “how are we gonna make it happen?”, and I have a couple of paths:
- Drop it and produce another proposal that uses a single heart icon, which would make it compatible with the icon API.
The problem here is that it would really be a pity to drop it and the alternative we find may really be suboptimal and not interesting, given that less than 20% of the existing XWiki instances use another icon theme than FontAwesome (20% is a personal feeling, I don’t have numbers to defend it). - Make the code icon theme aware and use this implementation for when the icon theme is FontAwesome and a “degraded” version for when the icon theme is something else.
TODO: We need to produce the degraded version that is comparable to this one. - Hardcode this UI to always use the FontAwesome icons, regardless of the current icon theme set on the wiki and consider that the heart is not an icon per se, but a “button in the shape of a heart” so we can draw it however we want, regardless of the icon theme.
Any opinions?