Logo upload fails on my MyXWiki instance

prozessarbeit-ch · February 16, 2025, 7:52pm

Hello,
I tried to upload a logo image for the header of my MyXWiki instance as described in https://www.xwiki.org/xwiki/bin/view/Documentation/UserGuide/GettingStarted/ChangingTheLogoAndThePanels. Pressing the ‘Upload and select’ action button has no effect. The user account is owner and admin of the MyXWiki instance, user type in profile is ‘Advanced’. I can upload logo images on my local Xwiki which I use for trial. It appears not to be general MyXWiki limitation: https://groeningerhof.myxwiki.org has its own logo. Any tipps to get logo images uploaded?

CharpentierLucas · February 17, 2025, 9:24am

I suppose you didn’t forget the start of the step where you need to browse for your logo on the local system file.

I tried to reproduce your issue locally and couldn’t:

Can you share a detailed description of what you tried, your client browser/OS versions and/or a video of you trying it out?

Thanks!

Lucas C.

PS: Just noticed that this post is under the myxwiki.org section, your instance version is known

prozessarbeit-ch · February 17, 2025, 1:00pm

Thanks for looking into this. Selecting the file works, the subsequent step ‘Upload and select’ doesn’t. When pressing the button the button becomes dark blue, no action follows, the ‘Attachments’ dialogue does not close, the file does not get uploaded. I tried it on a Mac with Safari 17.4.1 (here the image appears as mini icon next to file name), on a PC with Chrome 133. Tried it with different image formats, jpg, gif, svg.

CharpentierLucas · February 18, 2025, 9:25am

Thank you for the precisions! It confirms that it’s an issue that is specific to your instance and not standard XWiki.

From your tests, it seems like it isn’t just a browser specific issue (that we’d somehow have missed in our tests).

FYI the failing code is probably there: xwiki-platform/xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-ui/src/main/resources/XWiki/AttachmentSelector.xml at 1d9d01326a83c9816d9a8cfe5697dc147b40f877 · xwiki/xwiki-platform · GitHub

Do you get any XWiki notification (small popup at the bottom of the page, similar to what happens when you Save a page) to tell you that the request failed or nothing happens? If there’s nothing visible at first, can you check the logs in your console?

Lucas C.

prozessarbeit-ch · February 18, 2025, 4:24pm

No XWiki notification. This is what I get in the console:

CharpentierLucas · February 18, 2025, 4:38pm

Thanks for the info!

It looks like it’s an issue with some kind of configuration when you upload your picture.

github.com

xwiki/xwiki-platform/blob/4412a8957eeb0d2a87ae89871966e734037686ed/xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-validation/xwiki-platform-attachment-validation-ui/src/main/resources/XWiki/Attachment/Validation/Code/FileSizeValidation.xml#L175


      
                })),
                async: false,
                method: 'GET',
                success: function (getData) {
                  configCache[data.documentReference] = getData;
                }
              })
            }
            jsonString = configCache[data.documentReference];
          } else {
            jsonString = document.getElementById('attachment-validation-filesize-configuration').textContent;
          }
          const config = JSON.parse(jsonString);
          const maxFileSize = config.maxFileSize;
          const tooLarge = data.file.size &gt; maxFileSize;
          if (tooLarge) {
            const localizedMessage = l10n.get('errorMessage', data.file.name, formatBytes(data.file.size),
              formatBytes(maxFileSize));
            new XWiki.widgets.Notification(localizedMessage, "error")
            event.preventDefault();
          }

should be the place where you have the error.

I’m not sure why, but it seems the script tag with the id attachment-validation-filesize-configuration is not here when it should be.

Good luck on searching for the cause. The first check I’d do is to make sure the XWiki.Attachment.Validation.Code.FileSizeValidation hidden page was not edited on your wiki. Then if you can’t find anything here, you’ll need to dig a bit further with some web development tools to see what happens with this script element.

Lucas C.

prozessarbeit-ch · February 20, 2025, 4:25pm

Maybe the logo update problem is not specific to my MyWiki instance but others created around the same time could have it, without noticing it, as changing the logo is not typically done by the many who have an instance for personal use. The mentioned instance which has a changed logo is from 2023/03/22. Could others who have a recent instance check if it works for them?

prozessarbeit-ch · February 21, 2025, 10:11pm

News! Tonight I tried again to change the logo via Administer Wiki. It didn’t work. Then I had the idea that it might work to change the logo for a specific page. I then indeed managed to change the logo by administering the ‘home’ page for which I customised the color theme. I assumed that would only change it for that page or maybe the subpages, but it changed it for the entire wiki. And after that uploading an image also worked via Administer Wiki. Probably something to test whether this is reproducible on other new MyXWiki instances.

Johannes