Massive errors with Pro Macros since upgrade to Xwiki 15.9

Help / Discuss
1

Since the upgrade to Xwiki 15.9. (Debian 12.1, Tomcat9) all pages including Pro Macros have lots of errors like this:

Failed to execute the [include] macro. Cause: [Current user [xwiki:XWiki.USER] doesn't have view rights on document [test:Licenses.Code.VelocityMacros]].

In the tomcat logs, it shows up like this:

Error on too many recursive includes for topic Licenses.Code.VelocityMacro

and

WARN  c.x.x.XWiki                    - Exception Including Topic Licenses.Code.VelocityMacros 
com.xpn.xwiki.XWikiException: Error number 9001 in 9: Access to this document is denied:  Licenses.Code.VelocityMacros

I did not see this errors immediately, because as admin users, there are no errors, only for regular users.

We found this Code to execute

{{include reference="Licenses.WebHome" /}}

in the object editor at said page (https://wiki.example.org/wiki/test/edit/Licenses/WebHome?editor=object), could this be the issue?

Thanks in advance!

2

Hi,

I can’t reproduce on a clean XWiki 15.9 instance. Here’s what i did:

  • Created a simple user
  • Installed Pro Macros version 1.12
  • Got a trial license
  • Login with the simple user
  • Create a new page and add the Note and User Profile macros
  • Save the page

Everything was looking good. I don’t see any of the errors you mentioned. I also tried with the guest user and after a restart of the server. Same. Which of the Pro Macros give you the error? Are you using the latest version of the Pro Macros? Do you have a valid license listed in the “Licenses” administration section? Maybe something wrong happened during the upgrade.

Note that this forum is for the XWiki Open Source project, so you should report issues with paid extensions to the company that provides and maintains them. In this case I’d use the “Contact us” link on the top bar of https://store.xwiki.com/xwiki/bin/view/Extension/ProMacros/ , or the “Issues” link from the panel.

Hope this helps,
Marius

3

Thank you for your quick response!

Yes, 1.12

Yes, still valid for another year.

I did not see any errors, but maybe I did miss something… is there an option to see steps from the last upgrade in a log maybe?

Thank you, I will do that!

4

Issue has been resolved with the help of ProMacro Support, the culprit was a wrong permission (which I did not set, sounds like a regression in the latest update) one the Licenses page.

5

@Qua8zoh6, was the wrong permission a lack of view and/or script permission on the Licenses.Code space? We’re seeing this error, and if you’ve got the TL;DR version of what the problem and fix was, we’d be grateful.

6

Hi @lanedsmu, please check the permissions on this page in your wiki:

https://example.com/bin/admin/Licenses/WebPreferences?editor=spaceadmin&section=PageAndChildrenRights&space=Licenses#

if Unregistered Users have either view or edit permissions there, remove them completely.

Also check

https://example.com/bin/edit/Licenses/Code/VelocityMacros?editor=rights&force=1#

for the same thing. Hope that helps!

7

Beauty; thanks much!

8

Yesterday I upgraded from Version 15.10 to 16.4 and ran into the same error.

https://example.com/bin/admin/Licenses/WebPreferences?editor=spaceadmin&section=PageAndChildrenRights&space=Licenses#

On that page view and edit permissions for XWikiAdminGroup are set.
No permissions for Unregistered Users. Is that correct?

https://example.com/bin/edit/Licenses/Code/VelocityMacros?editor=rights&force=1#

No permissions are set here.

9

I just checked my installation: back then I removed all permissions, especially the XWikiAdminGroup, then it worked.

10

Thank you very much!

I cleared all permissions on the licenses page (in all Wikis) and it worked!
No errors any more! :+1:

11

I’m glad it worked for you too! :handshake:

Keep an eye out for these permissions, in my case they were restored after a Xwiki upgrade, but it got fixed in another release and I haven’t had any problems with it any more.