Migrate Syntax Highlighting code in xwiki-platform

Development
1

Hi everyone,

we currently bundle in XWiki Standard the Syntax Highlighting extension for having some interesting features with the Wiki editor.

I started for a few releases to improve a bit the wiki editor capabilities, which led of having to improve the Syntax Highlighting extension, but I think we should stop having them separated for some reasons:

  1. it’s an extension we bundle in XS, it makes sense to release its change at the same time we release XS
  2. there’s no real features that we are bringing on this extension that would work on older versions of XWiki, and on the contrary: currently it forces us to support legacy code in the extension. Having the code directly provided in platform would ensure that we don’t need anymore to support that compatibility as we’d ensure the extension is installed on the same version as the other resource files it relies on (e.g. simpletoolbar.js)

So wdyt about moving that code in xwiki-platform repository and cleaning up the old code kept only for legacy reasons, starting in 18.0.0?

2

+1 (even if it’s not a vote). I think we already voted the idea of having all code that we release in XS be part of the XWiki github organization.

That repo is the last remaining contrib extension AFAIK, right?

EDIT: Actually I see we’ve added a recent regression to this rule at xwiki-platform/xwiki-platform-core/xwiki-platform-blocknote/xwiki-platform-blocknote-api/pom.xml at 806ea3ba20149fbd44e472d5cbc6d8af3c0e5dbd · xwiki/xwiki-platform · GitHub (cc @mleduc ). I can see in the comments that it’s supposed to be temporary though :slight_smile:

3

+1, we are already supposed to not bundle any contrib extension, so that’s actually a bug to fix

4

+1 thanks!