Move DefaultAuthorizationManager to an internal package

Development
1

Hi everyone,

I discovered when working on it that DefaultAuthorizationManager currently belongs to the package org.xwiki.security.authorization making it de facto an API.
IMO that’s a mistake, as this component is an implementation and there’s no reason for it to be an API.

So my proposal is to move it to the package org.xwiki.security.authorization.internal starting in XWiki 17.0.0. This is a breaking API change, but I honestly doubt it would have any impact.

I’m opening this vote for 1 week until thursday 21st of november.

Here’s my +1.

Thanks

2

+1

3

+1 thanks

4

+1

Thanks,
Alex

5

Closing this vote with 4 +1. I created a ticket for doing the improvment: Loading...

6

There’s actually some impacts internally for the move: a few APIs, in particular in Right class, needs to be publicly exposed while they were package private before. See XWIKI-22683: Move org.xwiki.security.authorization.DefaultAuthorizationManager to internal package by surli · Pull Request #3791 · xwiki/xwiki-platform · GitHub so let me know if you want to change your opinion with that info: I will merge the PR at the end of the week if there’s no more comment.

7

FTR I’m putting the changes on hold for now since @MichaelHamann made good points against my proposed changes and there’s no hurry to perform this move.