Hi devs,
I’d like to fix Loading... (i.e. ability to not display the Likes column).
There are 2 options.
Option 1: Add a likes
parameter
- (+) Consistent with the existing
actions
parameter. See https://extensions.xwiki.org/xwiki/bin/view/Extension/Documents%20Macro#HParameterdefinitions - (-) Not consistent with the
columns
parameter which is supposed to support all valid coulmn values from the LT documentation (thus including_likes
and_actions
Option 2: Deprecate the actions
parameter
- (+) This means supporting the
_likes
and_actions
values in thecolumns
parameter (already supported) - Deprecate the
actions
parameter (see below for a detailed proposal of the deprecation)
In addition to these 2 options, we need to decide on the default behavior. Right now, the actions and likes column are displayed by default.
I’m proposing to break this behavior since I don’t believe users need/want the like column everywhere. I also believe it’s the same for the _actions
column and it shouldn’t be displayed by default (not all places where we display docs want to have the copy, rename, rights delete actions displayed).
Overall proposal
- Deprecate the
actions
parameter (and add support for specifying it in thecolumns
parameter), i.e. thecolumns
parameter takes precedence. Specifically:- If the
_actions
value is set explicitly in thecolumns
parameter then display the actions column, even if theactions
parameter is set tofalse
. - If the
columns
parameter is not set by the user (i.e. default is used), then display theactions
column if theactions
parameter is set totrue
.
- If the
- Don’t display Likes by default (and add support for specifying it in the
columns
parameter). - Document this change of behavior in the RN.
WDYT?
Thanks