Proposal: update the structure of the User display macro

Development
1

Hi!

Context

I was updating the selector rules for undelining, and I stumbled upon som UserDisplay velocity macro.
This macro is used in multiple places in the XWiki standard flavor UI.
See more on this PR.

Proposal

Change the structure of this macro. You can see the exact changes proposed on the PR linked above, here is a pseudocode highlight of the changes:

BEFORE:

<styleContainer>
  <avatar>
  <username> Alias </username>
</styleContainer>

PROPOSED:

<styleContainer>
  <username> <avatar> Alias </username>
</styleContainer>

Notes:

  • styleContainer is used to set the styles on all user displays (no semantics).
  • username is typically a <a>, it brings interactivity and semantics to the content.

Explanation

  • Putting the profile picture directly wrapped in username, which is often a link, allows users to click on the profile picture and get redirected to the profile. This could be considered as missing by some new users.
  • IMO this is clearer on the semantics level, it’s easy for anyone to understand that the profile picture is an alternative to the alias.

Conclusion

Do you agree with this change? Should we proceed with it?

Have a good day!
Lucas C.

2

I’m fine with the change but it needs a proper ticket + release notes about the dom change. And we should probably not backport that to LTS.

3

+1

6

Created https://jira.xwiki.org/browse/XWIKI-22269 :+1: