Remove RenderingTestSuite code

Development
1

Hi devs,

We normally don’t really need to ge formal agreement to remove test code but I’d like to make sure we agree.

The context:

  • Some time ago I had introduced a new JUnit5-based way to write rendering tests (using RenderingTests). I had kept the old JUnit4 way with @RunWith(RenderingTestSuite)
  • I’ve now migrated all our tests to use RenderingTests

The proposal:

  • To remove, in 17.0.0, the class we don’t use anymore: RenderingTestSuite

This means that if we have contrib extensions that update to 17.0.0+ and if they had rendering tests, they’ll need to adapt their tests. Fortunately:

  • There aren’t that many repos like this
  • It’s easy to convert

WDYT?

Thx

2

+1

Is it costly to still provide RenderingTests in a jar for projects that want to move to 17.0.0+ but don’t want to migrate their tests?
Note: a disadvantage of providing this legacy support is that it does not push devs to migrate to better test methods.

3

IMO it’s not worth it. What I can do if you think it’s needed (more work) is to write a short tutorial about it. Actually the simplest is to point to an example, for ex: [Misc] Convert another JUnit4-based rendering tests to JUnit5, removi… · xwiki/xwiki-platform@5dad14d · GitHub

Yes

4

+1 for deleting this (kind of) deprecated test framework

+1

5

Done: [Misc] Remove now unused RenderingTestSuite (all tests have now been … · xwiki/xwiki-rendering@aacd254 · GitHub

Thx