Remove the Google Ads feature from XWiki Standard

Development
1

Hi all,

I’d like to propose to remove the Google Ads feature from XWiki Standard.

Motivations:

  • it’s not a core feature and thus shouldn’t be in XS by default.
  • a clean implementation should aim for a more generic solution, not tide to a specific ad provider
  • the URLs used in the template does not exist anymore, and the feature is likely to be broken

The removal would consist of:

WDYT?

Thanks

Edit note: I changed the proposal from a move to legacy to an actual removal.

1 Like
2

Well, legacy is in XS by default.

I’m honestly not sure it makes much sense to keep this at all.

3

Same as Thomas, I’d be ok to remove it altogether (with just the info in the release notes).

It’s a very old feature that’s most likely never been used. See the comment at xwiki-platform/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/ad.vm at bd419a583691c1156a38e44022781ae876932da0 · xwiki/xwiki-platform · GitHub

I wouldn’t start a design page for an ad extension as I don’t see the need ATM.

PS: BTW if we moved to legacy we could also move the ad.vm template in the legacy jar as templates are supported inside jars.

4

And most likely not working as the URL at xwiki-platform/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/ad.vm at bd419a583691c1156a38e44022781ae876932da0 · xwiki/xwiki-platform · GitHub doesn’t exist anymore…

5

I don’t think we even need this at all, especially since 1) it’s broken and 2) it won’t do much without the java cod;e… (and it’s likely not the right HTML code anymore nowadays for embedding google ads)

6

Sorry, I meant to remove the “in the snippet” part when updating the proposal.

7

Same, +1 to remove it.

8

+1 too