Remove the mail plugin from platform

Development
1

Hi devs,

We’ve already decided to remove the mail plugin in https://markmail.org/message/b3lppo74m547xe5g

However, similar to Removal of SVG plugin I’d like to propose that we don’t move it to the attic for the same reasons (no doc on xwiki.org, no module for it, would take too much time to create a project and a pom for it for little value).

Would that be ok for you?

Thanks

2

You are talking only about MailPlugin, not MailSenderPluginApi, right ?

I had totally forgotten this thing even existed (I’m actually not sure I ever knew it did), and I really doubt anyone is using that. It’s not here to send mails but to read mails even if it’s not very clear to me how it finds it, it seems to be using a Servlet API to access them which suggest mails managed (or at least referenced) by the application server which is a strange concept to me.

So yes, +0.

3

yes :slight_smile: I’d like to remove this one too but that’s for later. First we need to remove its usage in the share page feature.

It was a POC to be able to update XWiki content by sending emails to XWiki AFAIR (on the xwiki side, I think it was reading emails from an inbox).

4

Since the link doesn’t work anymore, this is the mail plugin I’ve referring to: xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/mail at 456d6149d12d36f5481e70759e7974815591a2c1 · xwiki/xwiki-platform · GitHub

TBH the code is small and I don’t see the point of moving it to the attic so I’ll just remove it.

Thanks

5

Note that there’s one small problem: it’s referenced in xwiki-platform/xwiki-platform-distribution/pom.xml at e9a71776221d1a832f2a0f0220904e20678bbd6e · xwiki/xwiki-platform · GitHub and users would need to remove it from their xwiki.cfg file (I need to check if XWiki fails to start or just issues a warning).

WDYT?

6

Sure, but they are supposed to merge the xwiki.cfg file (and it’s automatic in the case of the Debian distribution), but it won’t hurt to indicate it specifically in the release note. We will get rid of all plugins eventually (hopefully).

It logs an error actually, but it does not stop XWiki.

7

Indeed just checked an FTR we get:

2025-05-20 17:16:15,170 [XWiki initialization] ERROR c.x.x.p.XWikiPluginManager     - Cannot initialize plugin [com.xpn.xwiki.plugin.mail.MailPlugin]. This plugin will not be available. 
java.lang.ClassNotFoundException: com.xpn.xwiki.plugin.mail.MailPlugin
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:440)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
        at org.xwiki.classloader.xwiki.internal.ContextNamespaceURLClassLoader.loadClass(ContextNamespaceURLClassLoader.java:176)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:467)
        at com.xpn.xwiki.plugin.XWikiPluginManager.addPlugin(XWikiPluginManager.java:83)
        at com.xpn.xwiki.plugin.XWikiPluginManager.addPlugins(XWikiPluginManager.java:118)
        at com.xpn.xwiki.XWiki.preparePlugins(XWiki.java:1654)
        at com.xpn.xwiki.XWiki.initXWiki(XWiki.java:1371)
        at com.xpn.xwiki.XWiki.initXWiki(XWiki.java:1293)
        at com.xpn.xwiki.XWiki.<init>(XWiki.java:1266)
        at com.xpn.xwiki.internal.XWikiInitializerJob.runInternal(XWikiInitializerJob.java:103)
        at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
        at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
        at java.base/java.lang.Thread.run(Thread.java:833)

So I feel it’s acceptable with the proper RN info.
Thx

8

Done in Loading...