Report Step of Distribution Wizard and delete/rollback actions

Hi everyone,

when performing a demonstration of how the Distribution Wizard worked in case of upgrades, I discovered the feature allowing to delete or rollback changes of a page that has just been installed.

This feature was apparently documented in the release notes here: https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWiki54RC1#HNewreportstep but it’s apparently not documented in https://www.xwiki.org/xwiki/bin/view/Documentation/UserGuide/Features/DistributionWizard#HReportstep

One of the major problem of the feature that I just reported is that currently there’s apparently no confirmation whatsoever to perform the actions: Loading...

But besides that big usability issue, I’m actually wondering about the real needs such feature covers: we are about to start some work on revamping DW and I’d like to know if that’s a feature we want to keep or if it’s something we could drop.

A quick discussion with @mflorea revealed that the feature might have been used when a configuration page is overridden following an upgrade. I can understand the need to keep the rollback feature for this, but certainly not the delete one. And then I’d enable the rollback feature only for configuration pages then.

And even there, it feels more like a feature to fix a bug than a real feature, so we would need proper report when needing to use it…

So I’d like feedbacks: has anyone ever used that feature on purpose? What’s the actual need?

Thanks

Maybe the main need is that page 3-way merges isn’t perfect (and cannot be), and we wanted users to be able to review changes and possibly undo errors. Not just for configuration pages but any page (users can edit any way).

I don’t see a lot of use cases for removing an added extension page though. I do see a need to be able to undo a delete page though (if you made changes you want to keep).

Note that the behaviour I taked about is not only displayed in case of upgrade, but also in case of fresh install where it really doesn’t make sense.

Honestly at this point I would be in favor of simply removing that feature in the next revamp of Distribution Wizard, to maybe reintroduce a new proper improvment later to indeed have a better view of what decisions had been taken during an upgrade and allow to properly revert them if needed (which is quite a different feature)

@tmortagne might remember as he implemented it but it could very well have been added as a request from users (especially users from XWiki SAS). To be verified.

@mflorea implemented it I think, which is why @surli discussed it with him I assume

ok thx. I would still ask XWiki SAS users about it.

Personally I’ve never used this screen and I agree it’s making the DW more complex than it should be, so if we keep it (i.e. if there are valid use cases for it, and I believe there are), I’d keep it but move it to a secondary action so that it isn’t displayed in the main wizard flow (users would need to explicitly click the secondary button “View Installation Report” or something like that.

On my side I wouldn’t necessarily get rid of the screen itself: I wasn’t really asking about the UC about having the view report about what’s been installed. My question was only about the delete/rollback actions features available in the same report.

But if we formalize a proposal to drop those features, part of the proposal might be to also make the view report optional.