Sporadic duplicate fullscreen button on wiki-edit (fresh sub-wiki, XWiki 17.10.1)

Help / Discuss
1

Hi everyone,

I would like to check whether others can reproduce the following editor issue, which appears to be related to a non-deterministic editor initialization (race condition).

Environment: XWiki 17.10.1

Reproduction steps

  1. Create a new sub-wiki using the standard flavor
  2. Open any page in wiki edit mode (/bin/edit)
  3. Reload the edit page multiple times (Ctrl+Shift+R)
  4. Observe the editor toolbar

Observed behavior

  • On many page loads, two fullscreen buttons are visible in the editor toolbar
  • On other page loads, only one fullscreen button is shown
  • The behavior changes simply by reloading the same editor page
  • When entering fullscreen mode, the duplicated fullscreen button remains visible in the fullscreen overlay (“fullscreen mirror”)

Observation

Case 1: duplicated fullscreen button
2 × #xwikieditcontentinner > div.leftmenu2 > img.fullScreenEditButton

Editor view
Editor view647×172 2.6 KB

Case 2: remaining fullscreen button additional to the close button
#xwikieditcontentinner > div.leftmenu2 > img.fullScreenEditButton
#xwikieditcontentinner > div.leftmenu2 > img.fullScreenCloseButton

Fullscreen view
Fullscreen view277×110 3.45 KB

Expected behavior

  • Exactly one fullscreen button should be displayed consistently
  • No leftover fullscreen edit button should remain visible in fullscreen mode

Question

Can others reproduce this on different setups? Is this a known issue?

2

Hi,

I recently fixed several problems related to the wiki editor toolbar and the injection of those fullscreen buttons, but it’s quite possible there’s still some regressions.

Could you first check that it’s not a cache issue in your browser: did you reproduce the problem after performing a hard refresh of the editor (ctrl + shift + r)?

Also, could you tell me where exactly you saw this behaviour: in the wiki editor or in the object editor? If it’s in the object editor, on which object type did you see it: it might help in particular to know the definition of the xclass, if it contained several text fields with different kind of editors.

If you’re still reproducing don’t hesitate to report a bug in jira.xwiki.org.

Thanks

3

Thanks for checking and follow-up questions. Confirmed after hard refresh and limited to the wiki editor. I’ve reported the issue as XWIKI-23846.