Hi everyone!
As part of the lightbox feature, I started to work on [XRENDERING-622] Mark images generated by the XWiki renderer - XWiki.org JIRA
for marking the images embedded by users inside the page content. The idea was to differentiate them of icons or other images provided maybe by a macro. This way the lightbox will be attached only to images generated by the (X)HTML renderers.
But there could be usecases where images that are not generated by a (x)html renderer should have a lightbox, or at least the user would expect them to have this feature. I think that this could easily happen with contributed macros that will display images, for their specific situation.
For this I propose to attach the lightbox by default on all the images inside the xwiki content and provide a class that can disable it for an element and it’s children. This way, any contributed code can choose to have or not this feature enabled, partially or complete, by using this class.
WDYT?