Table breaks when converting from HTML

Nimra · April 17, 2025, 1:59pm

Hello all,

when converting following HTML snippet to XWiki 2.1 syntax, the table will be broken. If the span has no attributes, the table is as expected. Why is that?

<table border="1">
<tr>
<td>var</td>
<td><span style="color: #0000ff;">asdf<br/></span></td>
</tr>
<tr>
<td>bar</td>
<td>function</td>
</tr>
</table>

(% border="1" %)
|var|(%%)(% style="color: #0000ff;" %)asdf

|bar|function

without style="color: #0000ff;":

(% border="1" %)
|var|asdf\\
|bar|function

and it is also okay if you add some text between <br/> and </span>:

(% border="1" %)
|var|(%%)(% style="color: #0000ff;" %)asdf
foo
|bar|function

so it seems like the escaping of newline is lost when an attribute is present

Nimra · April 22, 2025, 11:53am

I think the problem comes from around here, as in the example the new line is the last element of the table cell, but the next event will be endFormat so eventType.isInlineEnd() will not be true and therefore it will not be outputted as a line break.

github.com

xwiki/xwiki-rendering/blob/6e74ad34ed80126358b6d4440fcdcc5e064d58b2/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki20/src/main/java/org/xwiki/rendering/internal/renderer/xwiki20/XWikiSyntaxChainingRenderer.java#L359


      
              // paragraph, list or section header.
          
              // - If the new line is the last element of the paragraph, list or section header then it should be a line break
              // as otherwise it'll be considered as an empty line event next time the generated syntax is read by the XWiki
              // parser.
          
              if (getBlockState().isInLine()) {
                  if (getXWikiSyntaxListenerChain().getConsecutiveNewLineStateChainingListener().getNewLineCount() > 1) {
                      print("\\\\");
                  } else if (getXWikiSyntaxListenerChain().getLookaheadChainingListener().getNextEvent().eventType
                      .isInlineEnd())
                  {
                      print("\\\\");
                  } else {
                      print("\n");
                  }
              } else {
                  print("\n");
              }
          }

MichaelHamann · September 8, 2025, 9:13am

Thank you very much for this report and the excellent work at identifying the underlying problem. I’ve reported and fixed this as XRENDERING-798, the fix will be included in the next releases as indicated in the Jira issue.