Use buttons for deprecated properties action in object editor

Hi everyone,

as part of my work on Loading... I’d like to fix the UI for the “Remove [all] deprecated properties” action links we currently have in the object editor:

Those text in red bold are actual links, which is not obvious at all, and not consistent with any other link in XWiki. Also they’re supposed to be handled with an AJAX query to prevent the user leaving the editor when performing the action, so there’s no real point for them to be links as I don’t believe anyone would want to share them (and it wouldn’t work because of CSRF).

So my proposal is to change the links to use buttons with a `btn-danger` class, like this:

Note that in this first mockup I kept the inner html for both buttons, but I guess we should be consistent regarding the display of the cross icon: I guess we can have it in both buttons.

Are you ok with performing such change?

+1

Thanks
Marius

Seems like a logical solution, I like it.

Thanks

+1 as well, thanks

+1

Implemented in XWIKI-24320: Remove deprecated properties reload the editor · xwiki/xwiki-platform@79205e8 · GitHub