Hey everyone, as I would like to start contributing code to XWiki I started to work on updating the button that our users go to change their profile photo (the yellowish pencil+photo icon on top of the user picture). A small enough job to get acquainted to the workflow.
This button has some problems like:
It does not use the IconTheme, the image for the button is hardcoded.
It is a little bit “hidden”. At least it took me a while to find it on the page.
I could also try to use the IconTheme here, but this means I would need to change the AttachmentSelector component, and this could turn in a much bigger task than I can handle alone without dev assistance. It also means that I could break something somewhere else without realizing.
I started a draft PR here, so if you have some suggestions on the code and design, please let me know. Thanks to @CharpentierLucas for the nice introduction on the workflow.