Deprecate and remove Message Stream from XWiki Standard

[surli]

Hi everyone,

@vmassol started a brainstorming a while back for deciding the future of Message Stream and the answers point out towards deprecating and removing it from XS. So I’d like to make that decision official with a vote.

This vote is opened until next week wednesday 19th at 6PM.

Here’s my +1 for deprecating and removing it in future releases.

[vmassol]

+1 to remove the feature and redo it if it’s needed in the future (unless we discover that the feature is used actively by users - we should ask sponsoring companies if they have users using the feature).

[tmortagne]

@surli

deprecating and removing it

Which one ?

Deprecate now and remove it some time in the future ? Like 17.0.0 ?

[surli]

@tmortagne

@surli

deprecating and removing it

Which one ?

Deprecate now and remove it some time in the future ? Like 17.0.0 ?

Hmmm good point: I understood it as “remove everything related to Message Stream only from XS and deprecate / legacify all mixed APIs (e.g. stuff we have in notifications API that were used only for Message Stream”. Now maybe that’s not what @vmassol meant in first thread?

[vmassol]

What I wrote was:

1. Consider that the feature is deprecated and mark it as such in our documentation, and then we remove it altogether when we can. This also means that we can close as won’t fix all issues at Loading…

What this means was:

• Deprecate the message stream feature, i.e. mark it as such in the documentation (and indicate that it’ll be removed in version XXX. Also explain that if the feature is asked again, it would be implemented differently).
• Close the jira issues as won’t fix.
• Decide when to remove the feature (ie all code parts related to message stream). That could be either in 16.5+ or in 17.0.0, depending on the result of a discussion/proposal.

[Wardenburg]

+1 for depracation and removal

[lucaa]

I’m fine with removing it, +1.

However, the last time I checked, the wiki membership feature was using the message stream to send notifications to users (to admin when a user wants to join, to users when they’re invited by admin), so we may need to refactor that. I think there was an issue about improving those notifications, but I can’t find it now (maybe it was already done?)

[mleduc]

@vmassol

• Deprecate the message stream feature, i.e. mark it as such in the documentation (and indicate that it’ll be removed in version XXX. Also explain that if the feature is asked again, it would be implemented differently).
• Close the jira issues as won’t fix.
• Decide when to remove the feature (ie all code parts related to message stream). That could be either in 16.5+ or in 17.0.0, depending on the result of a discussion/proposal.

+1 for that (with version 17.0.0 as it’s too late for 16.5.x).

[surli]

@lucaa

However, the last time I checked, the wiki membership feature was using the message stream to send notifications to users (to admin when a user wants to join, to users when they’re invited by admin), so we may need to refactor that. I think there was an issue about improving those notifications, but I can’t find it now (maybe it was already done?)

So I checked this and indeed right now there’s a dependency to Message Stream. But, the feature is broken: apparently message stream related notifications are not received anymore since Loading.... Meaning that indeed users can write message to admin, but those won’t be received, they will only be displayed in the administration.
We will need to check what exactly we want to do with this when dropping Message Stream. Cleanest solution IMO would be probably to introduce a dedicated TargetableEvent for the Invitation application, and use those.

[surli]

And apparently I forgot to close the vote.
So with 5 +1 apparently everyone agrees on deprecating it, I will open a new proposal to decide exactly what we do and in which timeframe.

Thanks