Thx for looking into this, it’s a very important topic and I completely agree with you (and with Caty) on issue #1 that we’re not good-enough in the UX of changing XWiki logos.
I think we currently have several ways to change the logo and more just one:
- the one you mentioned from the Admin UI to change the theme (global level)
- by changing the logo in the Skins (global skin, space skin, skin of the user), see the logo xproperty in https://www.xwiki.org/xwiki/bin/view/Documentation/AdminGuide/Skins#HChangingtheSkin
- in the color theme but for a specific space only.
- (technical) with Very basic question: changing logo - #5 by pjeanjean or by using xobject editors in general
Other problems to solve ideally:
- There also seems to be this problem: Very basic question: changing logo - #2 by pjeanjean
- Some other problem to solve: Logo Change - Flamingo Theme Not Updating
This is to say that in your proposal you need to take into account:
- what logo the user wants to change: the global one, a space logo, a page logo (maybe even a specific logo for a user - for ex if we want to allow a theme selected for a user in the future)
- differentiate between skin logo and color theme logo. Either propose to drop the concept of logo for a skin or the color theme logo should override the skin logo (color themes apply on top of skins).
I see you’ve mentioned “if it’s a default logo or not”. WDYM by a default logo? Is it the default skin logo (ie when logo is explicitly defined for a skin)?
EDIT: I see that in the " What we should have" section you do mention skin logos vs theme logos. I found it strange that you didn’t mention this in the " What we currently have" section. I still think you’re missing the concept of wiki logo vs space logo vs page logo (vs user logo in the future if we implement user themes).
I think you mean removing the UI for:
- logo xproperty in the edit sheet for a skin
- logo xproperty in the edit sheet for a theme
Is that so?
Technically we’d still need to keep the various logo xproperties.
Side note: I think that we should consider skins as some advanced topic, and thus hide it more vs themes, so that users are less confused.
- If the logo name is changed, does it mean that the logo attachment is renamed?
- I’m not sure I understand what is a defaut logo. If you’re talking about a default skin logo, I don’t think we can change that, it’s supposed to be fixed/hardcoded.
Technically I guess this could be implemented as a LiveData with a card layout.
Shouldn’t we highlight the logo used currently (ie for the current skin and current theme)? In your example there are several logos set for Flamingo skin, but only a single logo can be set for a skin, is that just a mistake of the example?
I like the idea of a single place with a global overview for the logos.
I’m assuming that in your proposal the same UI would exist at the level of space admin and page admin. But then, users will not have a global view of why a given logo is displayed or not displayed at a given location in the wiki. Is this a problem?
I find it a bit weird that we’d essentially remove ability of setting the logo for a skin or for a theme when editing the skin or the theme.Then we offer a single UI but then when adding a logo you have to decide if it’s a theme logo or a skin logo. So users need to understand the concepts of theme logo vs skin logo.
Let me play the devil’s advocate (for the sake of discussion): How is your UI simpler than what we have now? For me, the proposed UI is quite more complex as you need to understand the concepts of skin logo, theme logo, etc. whereas right now you just go to the L&F > Theme UI and change the logo there for the selected theme. What’s complex right now is the skin concept since you can also change the logo there and users may be confused. But if we “hide” the skin as something advanced, maybe it’s less an issue?
Global Admin > 1) Look & Feel > 2) Themes > 3) Customize theme > 4) Choose an attachment > 5) Actions around logo (at least 6 clicks)
With your proposal, it’s:
*Global Admin > 1) Look & Feel > 2) Themes > 3) Logos > 4) Click upload logo > 5) Fill “usage of themes”, fill “usage in skins”, click “submit”.
That’s at least 6 clicks (and possibly 8). So the same in term of complexity…
I need to think more about this but I’m curious to see the feedback of others.
Ludovic also mentioned, as an idea, that we could have a DW step to let the user select a logo since it’s a very common task that almost everyone needs to do when you set up a wiki. This is separate from this proposal but it’s related so I thought it should be mentioned. If we have this then the need to change the logo and finding how to do this is a bit less needed.
Thanks a lot for working on this topic and making a proposal to make the topic progress! 