Prevent editing source translations in l10n platform

Development
,
1

Hi everyone,

we have a translation pull requests opened for a few days containing changes on the source translation file of an xwiki core component. Apparently the author of those changes decided on his own to fix a problem with a localization string that impacts the UI by editing the source translation in Weblate.

For me this raises two problems:

  1. it means right now anyone can edit the source of all translations (considered as the basis for all translations files) without a clear JIRA ticket even if it can impact the UI
  2. currently we don’t have a proper support of handling changes in Weblate without changing the format of a translation file: it’s not really a problem for most translations files since they are edited through Weblate so they always keep same format. It’s more a problem for the source translation file since this one might contain some new lines to separate sections that might be lost once edited in Weblate

So in order to avoid those problems in the future, I propose that we disable systematically the capability to edit the source file of a component in weblate.
This can be done by going into “Management > Settings” of a component and then in “Files” tab by unchecking the “Edit base file” box, see:
image

Unless someone disagrees, I’ll do that shortly for all xwiki components. For contrib extension components I’ll leave it to the appreciation of the different dev of each extensions.
Regarding the current state of the PR, I opened a ticket for the change that has been done and we’ll handle that separately.

2

+1 as iiuc it’s only for technical operations and not impacting normal translation operations.

3

+1

4

+1

Thanks,
Alex

5

I assume, that I am the author, that messed around with Weblate to rigorously and I am sorry for creating some irritation. When I was working with the Weblate UI I noticed a “Suggest” button and a “Save and continue” button. It was not clear to me what the difference was, so I chose the seemingly more direct “Save and continue”. If this option would be deactivated and the general process of changing translations would be described somewhere, that would probably help to avoid such “bad contributions” as mine apparently was. Sorry again, and glad @surli took over to avoid any possible breaking changes.

6

Thanks but if somebody has to be sorry it’s more us: there was a flaw in our process and you just happened to show it to us :slight_smile:

2 Likes
7

The proposed change have been applied on the translation platform.