Thanks for your feedback!
I don’t agree with this fix, because I think a strength of the icon set is the easiness of the names. Systematically adding prefixes will make using this feature more difficult than it needs to be. AFAIK we don’t have specific icons for moving pages or moving attachments in the iconset so this lack of specificity is not an issue. I agree that caret-left and move have different naming conventions (based on the character vs based on semantics), but it’s something that’s already in the iconset with ‘add’ and ‘caret-right’ for example. I don’t think this is much trouble for devs so I’m in favor of keeping things the same.
Unfortunately, silk was created in 2005 and not updated for a long time, so there’s some huge holes in its icon theme cover. When checking out a list of the icons in silk, I could not find anything closer to those we would expect for those actions.
I think it’s more important to have an icon set that can represent a variety of icons, even if silk is a bit left behind. If we don’t provide enough icons in the set, devs will need to:
- hard code icons, defeats the purpose of having an icon set (see Loading...).
- use icons that are not appropriate to the context. E.g. using a burger menu icon instead of a move icon
It’d be nice to find a better mapping for those, any suggestion is welcome .
AFAICS a lot of icons in the set are in the same situation as of now (see the icon set definition). I thought this would be okay.
I don’t mind too much leaving the bell icons for a later update because the only theme where these variations really make sense is FA, and we’re still lacking one icon for the full UI revamp proposed in https://design.xwiki.org/xwiki/bin/view/Proposal/Notificationwatchbuttons#HUsingbells / Complete redesign of notification watch buttons - #16 by tkrieck .