Unfortunately, silk was created in 2005 and not updated for a long time, so there’s some huge holes in its icon theme cover. When checking out a list of the icons in silk, I could not find anything closer to those we would expect for those actions.
Regarding silk shouldn’t we just start deprecating it? As you said it’s starting to get old, and I think we’re all more relying on FA those days than on silk. IMO it would make sense to deprecate it and stop bundling it in the future, maybe when we move to 16.x or 17.x.
Sounds good generally speaking, but could you explain precisely what you mean by deprecating? I think we need to make sure that contrib extensions (or custom code) continue to work if they use Silk. Does deprecating mean that when using Silk in future XWiki versions, the UI would get broken? IMO, one simple solution that could be acceptable would be that each icon set could provide a default icon when no mapping exists for a specific name. That would allow Silk to continue “working” (even if it would be with icons not nice) in the future, at a low cost.
So to be clear this proposal is about:
- documenting that Silk should not be used anymore in new code, in favor of FA theme: this documentation should go in dev best practices, and in the documentation regarding the extension theme / icon extension. That’s what I meant first by “deprecating”
- open a vote for stop bundling silk in a future version of XWiki and move it to contrib: as part of this change we might decide to introduce a default icon as fallback to avoid problems on older extensions